[feature] Ability to specify maxWidth or maxHeight#51
Open
initplatform wants to merge 3 commits intoDonaldcwl:masterfrom
Open
[feature] Ability to specify maxWidth or maxHeight#51initplatform wants to merge 3 commits intoDonaldcwl:masterfrom
initplatform wants to merge 3 commits intoDonaldcwl:masterfrom
Conversation
Owner
|
@initplatform Good suggestions! For the implementation, I think the performance will be better if we combine all three functions |
Author
|
cool. Makes sense. I can take a stab at it, but it might be a week or so before I get a free cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Donaldcwl great work putting this together.
There are certain scenarios that require specifying a maxWidth or a maxHeight specifically. I added both options.
Also added 2 test to test them.